|
|
Post by Kareem Abdul-Jabbar on Mar 8, 2018 0:46:31 GMT -5
billy, did you check the changes here man? I believe it's huge. ^^
|
|
billy
 Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Mar 8, 2018 10:07:00 GMT -5
Yeah, Kareem. I tried out the beta when it was announced a month ago or so. It actually doesn't really produce vastly different results when we import our players. However, I'm going to finish out the season with the old version.
As a league we will move to the new version of basketball-gm for the 2018-2019 season, though. It is actually much much better when it comes to making players. The extreme ratings are now much much more extreme. We will no longer have to have 30 players with 100 rebounding, and we will be able make a player like Steph Curry accurately!
However, giving us the offseason and dead season to prepare for the new sim engine seems to be the best decision in my mind. No reason to change the rules halfway through the game.
|
|
Theodore Duncan
 Portland Trail Blazers
Posts: 1,636 
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Mar 8, 2018 10:24:48 GMT -5
imgur.com/disHhZlThat's the screenshot of the new sim version and the ratings from a league file from few weeks back I think. Some players got nerfed big time, some stayed about the same. But looks like less players indeed with extreme high ratings
|
|
|
|
Post by Ron Artest(1x Champ) on Mar 8, 2018 12:10:39 GMT -5
Why is Kawhi rated so high if he’s been injured all season?...
|
|
|
|
Post by Justin Timberlake on Mar 8, 2018 13:12:10 GMT -5
Why is Kawhi rated so high if he’s been injured all season?... Injury doesn't and shouldn't affect his skill unless there is evidence that it has |
|
|
|
Post by Ron Artest(1x Champ) on Mar 8, 2018 13:26:57 GMT -5
I guess
|
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Mar 8, 2018 13:48:38 GMT -5
We have an injury system to remove them if they're injured for awhile. |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Mar 12, 2018 22:35:08 GMT -5
Dumbmatter posted some quick instructions to play the old version in a comment on reddit, it is as follows:
The following is the readme:
# Basketball GM 4.0.0
A single-player basketball simulation game. Make trades, set rosters, draft
players, and try to build the next dynasty, all from within your web browser.
The game is implemented entirely in client-side JavaScript, backed by IndexedDB.
Copyright (C) Jeremy Scheff. All rights reserved.
* Email: commissioner@basketball-gm.com
* Website: <https://basketball-gm.com/>
* Development: <https://github.com/dumbmatter/basketball-gm>
* Discussion: <http://www.reddit.com/r/BasketballGM/>
**Basketball GM is NOT open source, but it is also not completely closed. Please
see LICENSE.md for details.**
## Development Info
If you just want to play the game, go to <http://basketball-gm.com/>.
Instructions below are for developers who want to run a copy locally so they can
make changes to the code.
If you want to contribute but get stuck somewhere, please contact me! I'm happy
to help.
### License and Contributor License Agreement
**Basketball GM is NOT open source, but it is also not completely closed. Please
see LICENSE.md for details.**
If you want to contribute code to Basketball GM, you must sign a contributor
license agreement. There are separate forms for individuals and entities (such
as corporations):
* [Individual CLA](CLA-individual.md) (this is probably what you want)
* [Entity CLA](CLA-entity.md)
Make a copy of the form, fill in your information at the bottom, and send an
email to commissioner@basketball-gm.com with the subject line, "Contributor
License Agreement from YOUR_NAME_HERE (GITHUB_USERNAME_HERE)".
### Step 1 - Installing
First, make sure you're using [Node.js](https://nodejs.org/) v6 or higher, older
versions probably won't work. Then, all of the tooling used in development can
be set up by simply installing [npm](https://www.npmjs.com/) and running
npm install
from within this folder.
### Step 2 - Building
Basketball GM uses Browserify for JS minification and clean-css for
CSS minification. To build the app along with all its assets, run
npm run build
However during development, you probably would rather do
npm run start-watch
which will start the server and watch JS and CSS files for changes and
recompile. This simply runs both `npm start` and `npm run watch` together, which
alternatively can be run separately if you wish.
Open `package.json` to see all available scripts.
### Step 3 - Running
To run the game locally, you need some way of running a web server to display
the content. There are currently two ways to do it. It doesn't matter which
you use as long as you can get it to run on your computer.
#### 1. Node.js (easiest)
Run
npm start
and point your browser to <http://localhost:3000/>. If you use the command
`npm run start-watch` from above, then running the command `npm start` is not
necessary.
#### 2. Apache
The mod_rewrite rules in `.htaccess` can be used to make Apache run Basketball
GM. Everything should work if you point it at the `build` folder with
mod_rewrite enabled. That's how it's done on play.basketball-gm.com.
### Step 4 - Testing
ESLint, Flow, and, stylelint are used to enforce some coding standards. To run
them on the entire codebase, run
npm run lint
Integration and unit tests are bunched together in the `js/test` folder.
Coverage is not great. They can be run from the command line in Karma with
npm test
or
npm run test-watch
or manually within a web browser by running `npm run build-test` (or
`npm run watch-test`) and going to <http://localhost:3000/test> (this might be
broken currently).
### Code Overview
Basketball GM is a single-page app that runs almost entirely client-side by
storing data in IndexedDB. The core of the game runs inside a Shared Worker (or
a Web Worker in crappy browsers that don't support Shared Workers), and then
each open tab runs only UI code that talks to the worker. The UI code is in the
`src/js/ui` folder and the core game code is in the `src/js/worker` folder. They
communicate through the `toUI` and `toWorker` functions.
The UI is built with React and Bootstrap.
In the worker, data is ultimately stored in IndexedDB, but for performance and
cross-browser compatibility reasons, a cache (implemented in
`src/js/worker/db/Cache.js`) sits on top of the database containing all commonly
accessed data. The idea is that IndexedDB should only be accessed for uncommon
situations, like viewing stats from past seasons. For simulating games and
viewing current data, only the cache should be necessary.
The cache is overly complicated because (1) the values it returns are mutable,
so you better not mess with them accidentally, and (2) when you do purposely
mutate a value (like updating a player's stats), you need to remember to always
write it back to the cache manually by calling `idb.cache.*.put`.
Also in the worker, there is a global variable `self.bbgm` which gives you
access to many of the internal functions of Basketball GM from within your
browser.
### Git Workflow
If you want to contribute changes back to the project, first create a fork on
GitHub. Then make your changes in a new branch. Confirm that the tests
(hopefully including new ones you wrote!) and ESLint all pass. Finally, send me
a pull request.
It's also probably a good idea to create an [issue on
GitHub](https://github.com/dumbmatter/basketball-gm/issues) before you start
working on something to keep me in the loop.
## Less Important Development Info
### Bootstrap
Basketball GM's layout is currently based on Bootstrap 3.1.1 with the following
options:
* @font-size-base set to 13px
### Basketball stuff
Abbreviations of stats should be done like basketball-reference.com stat pages.
For instance, "defensive rebounds" is "drb".
### Cordova
The game runs equally well within a web browser and within Cordova (Android
4.4+). The codebase is designed to handle both situations (the main difference
is absolute vs relative paths, governed by window.inCordova in index.html).
Warning: This hasn't been tested in a while and is probably broken by now.
### Thank you BrowserStack
Shout out to [BrowserStack](https://www.browserstack.com/) for helping with
cross-browser testing.
|
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 3, 2018 9:43:11 GMT -5
Ok..I guess I'm bit more IT-challenged as I thought I would be. Can someone ELI5 this? I have installed node.js and yarn as the instructions say? Now what?  I'm using mac. Do I now just write those commands on terminal? And how do I do this.. "and point your browser to localhost:3000 ?? |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 3, 2018 11:02:12 GMT -5
Ok..I guess I'm bit more IT-challenged as I thought I would be. Can someone ELI5 this? I have installed node.js and yarn as the instructions say? Now what? I'm using mac. Do I now just write those commands on terminal? And how do I do this.. "and point your browser to localhost:3000 ?? Do you have git installed? |
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 3, 2018 13:14:33 GMT -5
Ok..I guess I'm bit more IT-challenged as I thought I would be. Can someone ELI5 this? I have installed node.js and yarn as the instructions say? Now what? I'm using mac. Do I now just write those commands on terminal? And how do I do this.. "and point your browser to localhost:3000 ?? Do you have git installed? I installed it now. Then what? |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 3, 2018 13:58:37 GMT -5
Do you have git installed? I installed it now. Then what? 1. Open a terminal 2. Type: cd ~ Press enter 3. Type: mkdir BBGM Press enter 4. Type: cd ./BBGM Press Enter 5. Type the first git command listed in OP Press Enter 6. Type the second git command listed in OP Press enter 7. Type: cd ./basketball-gm/ Press Enter 8. Type: npm install Press Enter then follow onscreen prompts 9. Type: npm run build Press Enter then follow onscreen prompts Should launch server 10. Open browser, type in http://localhost:3030 into your browser, and BBGM should be there. These could be slightly off, let me know if something doesn’t work and where and ill fix it |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 9, 2018 7:59:55 GMT -5
Anyone got this running yet?
|
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 9, 2018 11:20:16 GMT -5
Yeah it doesn't work. I have no idea what I'm doing. :)
I installed Git-up (?), probably that was not right since nothing happened. So I made then a GitHub.com account, but have no idea what to do there.
Do I really have to also register this "License and Contributor License Agreement" for BB-GM by linking my GitHub account?
Then this step is not really clear:
Then, all of the tooling used in development can be set up by simply installing [npm](https://www.npmjs.com/) and running
If I go to the npmjs.com site there is just thousand difference packages, so it's not clear and simple what to install and how :)
|
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 9, 2018 11:21:54 GMT -5
simplest would be probably to do the steps in your screen and record it for help video
|
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 9, 2018 15:07:45 GMT -5
|
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 10, 2018 1:55:05 GMT -5
ok it seems I have git and npm both.
git version 2.16.3 and when I wrote npm --version, it says 5.6.0 |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 10, 2018 8:00:26 GMT -5
ok it seems I have git and npm both.
git version 2.16.3 and when I wrote npm --version, it says 5.6.0 Alright, go ahead and try out the process I outlined above and see if it works. Here's an english paragraph version of what I told you to do above: Git is basically just a client to download a folder from online. You dont have to worry about having anything from github. You basically navigate to a place on your computer (the cd [change directory] commands I wrote), and then you make a folder and then "git clone" it and it downloads the folder from his git repo to that place on your computer. Then you just navigate into the folder and install npm inside of it. |
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 10, 2018 8:12:25 GMT -5
Ok I think I get it now. I got the first command working. I first thought that it's just the link to the instructions of the developer
git clone github.com/dumbmatter/basketball-gm.git (this worked for me only if left the .git ending out)
git checkout before-player-ratings-changes (This doesn't work. I get message "fatal: Not a git repository (or any of the parent directories): .git"
|
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 10, 2018 8:24:08 GMT -5
Ok I think I get it now. I got the first command working. I first thought that it's just the link to the instructions of the developer git clone github.com/dumbmatter/basketball-gm.git (this worked for me only if left the .git ending out) git checkout before-player-ratings-changes (This doesn't work. I get message "fatal: Not a git repository (or any of the parent directories): .git" Ah, you have to cd into the basketball-gm folder you just downloaded. If you can't figure it out upload a screenshot |
|
Theodore Duncan
Portland Trail Blazers
Posts: 1,636
Likes: 1,414
Total Bank: 57,500
|
Post by Theodore Duncan on Apr 10, 2018 8:35:16 GMT -5
Hah. I got the sim working. Thanks Billy In your instructions point 10
(Open browser, type in into your browser, and BBGM should be there.)
the address itself "http://localhost:3000/" has disappeared. I had noticed that happened also when I tried to post my first question to the thread |
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Apr 10, 2018 10:36:59 GMT -5
Hah. I got the sim working. Thanks Billy In your instructions point 10
(Open browser, type in into your browser, and BBGM should be there.)
the address itself "http://localhost:3000/" has disappeared. I had noticed that happened also when I tried to post my first question to the thread Great! Fixed. From this time on you don't have to do all the above steps. To relaunch the sim, just open a terminal inside the basketball-gm folder and type: npm start then press enter |
|
|
|
Post by Tracy McGrady on Jul 16, 2018 11:32:46 GMT -5
Can you share the file we are using please?
|
|
billy
Miami Heat
Posts: 7,174
Likes: 6,145
Total Bank: 3,050
|
Post by billy on Jul 16, 2018 12:03:58 GMT -5
|
|
Brooklyn Nets
LA Lakers
Phoenix Suns
